[krita/video-export-rebased] libs/ui: Save to a temporary file, then copy the result over on success (fwd)

[Dmitry Kazakov]

On Tue, Aug 16, 2016 at 7:12 PM, Boudewijn Rempt <boud at valdyas.org> wrote:

> On Tue, 16 Aug 2016, Dmitry Kazakov wrote:
>
> > Can we somehow limit this behavior to network files only?
>
> I would prefer not to. This also solves the issue we've seen where a
> failure to save breaks the original file.


That is a good point, yes.


> > 1) If some other application, like Blender, is waiting on Krita-edited
> file
> > with inotify (QFileSystemWatcher), it may go crazy when we rename and
> > delete the file. The inotify opject will be destroyed after that.
>
> Did you test that, or is this just a hunch?
>

Just a hunch. Needs to be tested before the merge.


>
> > 2) What if the user works with 700MiB image? It mean he needs twice the
> > size of the image free space just to be able to save it. Many people will
> > be unhappy with it.
>
> But far fewer people than are currently unhappy because our unsafe saving
> code breaks their files. And if the file hasn't been saved before there is
> no extra disk space needed,


I agree, then we should probably have some clever choice of the temporary
file folder? Like "if the saving to /tmp failed due to the lack of space,
try saving into the same directory as the destination file". That will
solve the issue for people who have different partitions for /home and /.
Or just make it configurable somehow...

I know a lot of people who give quite small partitions to Windows (~50GiB)
and use a separate partitions/drives for their working folders.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kimageshop/attachments/20160817/363bef17/attachment.html>