Need review and testing for 'zoom-pan-testing-kazakov' branch

[Boudewijn Rempt]

On Sunday 02 September 2012 Sep, Dmitry Kazakov wrote:
> Hi!
> 
> I've just finished the branch which fixes various zoom/pan bugs in Krita
> and adds comprehensive testing for it. It would be really cool if someone
> could test it and review before I merge it to master. I send the mail to
> calligra list as well, because it touches a couple of classes in
> ./libs/flake/ as well.
> 
> This branch touches KoCanvasControllerWidget, so, theoretically, it may
> affect other applications, so it might be necessary to check them for
> regressions as well. I checked Karbon and it seems to work fine.
> 
> What should be tested in Krita:
> 1) Usual Zoom and Pan
> 2) Zoom and Pan in Fullscreen mode
> 3) Zoom and Pan on rotated canvas
> 4) Zoom and Pan on mirrored canvas
> 5) (optional) Zoom and Pan with VastScrolling disabled.
> 
> In other applications:
> 1) There should be no regressions ;)
> 
> 
> Thank you in advance!
> 
> 
> PS:
> 
> Small howto:
> The changes are in the branch 'zoom-pan-testing-kazakov'. So to check you
> need to switch to it:
> 
> git fetch
> git checkout origin/zoom-pan-testing-kazakov
> <build your Krita>
> 
> To switch back to master:
> 
> git checkout master
> 
> 

I get a compile error in a plugin:

/home/boud/kde/src/calligra/plugins/spacenavigator/SpaceNavigatorDevice.cpp: In member function ‘void SpaceNavigatorDevice::slotMoveEvent(int, int, int, int, int, int, Qt::MouseButtons)’:
/home/boud/kde/src/calligra/plugins/spacenavigator/SpaceNavigatorDevice.cpp:92:80: error: no matching function for call to ‘KoCanvasController::zoomBy(QPointF, double)’
Linking CXX executable TestSpellCheck
/home/boud/kde/src/calligra/plugins/spacenavigator/SpaceNavigatorDevice.cpp:92:80: note: candidate is:
/home/boud/kde/src/calligra/libs/flake/KoCanvasController.h:219:18: note: virtual void KoCanvasController::zoomBy(const QPoint&, qreal)
/home/boud/kde/src/calligra/libs/flake/KoCanvasController.h:219:18: note:   no known conversion for argument 1 from ‘QPointF’ to ‘const QPoint&’
make[2]: *** [plugins/spacenavigator/CMakeFiles/spacenavigator.dir/SpaceNavigatorDevice.cpp.o] Error 1
make[1]: *** [plugins/spacenavigator/CMakeFiles/spacenavigator.dir/all] Error 2

(not a big deal, but I'm not sure whether you forgot to port other parts of calligra too)

-- 
Boudewijn Rempt
http://www.valdyas.org, http://www.krita.org, http://www.boudewijnrempt.nl