[calligra/krita-fixsmudgebrush-silvioheinrich] krita/plugins/paintops: Added mode to use the projected image (all visible layers merged) as source layer for smudging.

[Sven Langkamp]

On Sat, Feb 19, 2011 at 1:55 PM, Silvio Heinrich <plassy at web.de> wrote:

> On 02/18/2011 09:05 AM, Boudewijn Rempt wrote:
> > On Friday 18 February 2011, Silvio Heinrich:
> >> I had a discussion with Sven about that this functionality would be good
> >> for the filter brush, too.
> >> And after a bit of thinking I believe it could be useful for more
> PaintOps.
> >> For example the deform brush and even the standard pixel brush (when
> >> painting with composite option different then "normal").
> >> So I would suggest to have a checkbox for this feature in the "Tool
> >> Options" underneath the "Assistant" checkbox.
> >> And then add a few methods to the KisPaintOp class:
> >>
> >> class KRITAIMAGE_EXPORT KisPaintOp : public KisShared
> >> {
> >>       ...
> >>       virtual bool supportsMergedPainting() const { return false }
> >>
> >>       void enableMergedPainting(bool enable) { m_mergePaintingEnabled =
> >> enable; }
> >>       bool mergedPaintingEnabled() const     { return
> >> supportsMergedPainting()&&  m_mergePaintingEnabled; }
> >>       ...
> >>
> >> So a PaintOp that will support merged painting can overwrite
> >> supportsMergedPainting() and return true and
> >> we can test from the outside if this mode is supported an enable/disable
> >> the checkbox accordingly.
> >> Every derived PaintOp can test if the mode is enabled with
> >> mergedPaintingEnabled() an can switch to the needed
> >> logic then.
> >>
> >> Just tell me your opinion (talking to all devs). Or maybe someone has a
> >> better solution for this :D.
> >>
> >>
> > It sounds good to me! I got this mail privately, maybe we should open up
> the discussion on the mailing list.
> >
> :-/ was a mistake. It was supposed to go to the list :D
>

I tried the branch, but did get very smooth results for smudge. Looks like
this: http://i.imgur.com/z1NaK.png
I haven't compared to the old smudge, but this looks wrong to me.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kimageshop/attachments/20110222/252d1fe5/attachment.htm