<div class="gmail_quote">On Sat, Feb 19, 2011 at 1:55 PM, Silvio Heinrich <span dir="ltr"><<a href="mailto:plassy@web.de">plassy@web.de</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
On 02/18/2011 09:05 AM, Boudewijn Rempt wrote:<br>
> On Friday 18 February 2011, Silvio Heinrich:<br>
>> I had a discussion with Sven about that this functionality would be good<br>
>> for the filter brush, too.<br>
>> And after a bit of thinking I believe it could be useful for more PaintOps.<br>
>> For example the deform brush and even the standard pixel brush (when<br>
>> painting with composite option different then "normal").<br>
>> So I would suggest to have a checkbox for this feature in the "Tool<br>
>> Options" underneath the "Assistant" checkbox.<br>
>> And then add a few methods to the KisPaintOp class:<br>
>><br>
>> class KRITAIMAGE_EXPORT KisPaintOp : public KisShared<br>
>> {<br>
>> ...<br>
>> virtual bool supportsMergedPainting() const { return false }<br>
>><br>
>> void enableMergedPainting(bool enable) { m_mergePaintingEnabled =<br>
>> enable; }<br>
>> bool mergedPaintingEnabled() const { return<br>
>> supportsMergedPainting()&& m_mergePaintingEnabled; }<br>
>> ...<br>
>><br>
>> So a PaintOp that will support merged painting can overwrite<br>
>> supportsMergedPainting() and return true and<br>
>> we can test from the outside if this mode is supported an enable/disable<br>
>> the checkbox accordingly.<br>
>> Every derived PaintOp can test if the mode is enabled with<br>
>> mergedPaintingEnabled() an can switch to the needed<br>
>> logic then.<br>
>><br>
>> Just tell me your opinion (talking to all devs). Or maybe someone has a<br>
>> better solution for this :D.<br>
>><br>
>><br>
> It sounds good to me! I got this mail privately, maybe we should open up the discussion on the mailing list.<br>
><br>
:-/ was a mistake. It was supposed to go to the list :D<br>
</blockquote></div><div><br></div>I tried the branch, but did get very smooth results for smudge. Looks like this: <a href="http://i.imgur.com/z1NaK.png">http://i.imgur.com/z1NaK.png</a><div>I haven't compared to the old smudge, but this looks wrong to me.</div>