[calligra/krita-fixsmudgebrush-silvioheinrich] krita/plugins/paintops: Added mode to use the projected image (all visible layers merged) as source layer for smudging.

Silvio Heinrich plassy at web.de
Sat Feb 19 13:55:27 CET 2011


On 02/18/2011 09:05 AM, Boudewijn Rempt wrote:
> On Friday 18 February 2011, Silvio Heinrich:
>> I had a discussion with Sven about that this functionality would be good
>> for the filter brush, too.
>> And after a bit of thinking I believe it could be useful for more PaintOps.
>> For example the deform brush and even the standard pixel brush (when
>> painting with composite option different then "normal").
>> So I would suggest to have a checkbox for this feature in the "Tool
>> Options" underneath the "Assistant" checkbox.
>> And then add a few methods to the KisPaintOp class:
>>
>> class KRITAIMAGE_EXPORT KisPaintOp : public KisShared
>> {
>>       ...
>>       virtual bool supportsMergedPainting() const { return false }
>>
>>       void enableMergedPainting(bool enable) { m_mergePaintingEnabled =
>> enable; }
>>       bool mergedPaintingEnabled() const     { return
>> supportsMergedPainting()&&  m_mergePaintingEnabled; }
>>       ...
>>
>> So a PaintOp that will support merged painting can overwrite
>> supportsMergedPainting() and return true and
>> we can test from the outside if this mode is supported an enable/disable
>> the checkbox accordingly.
>> Every derived PaintOp can test if the mode is enabled with
>> mergedPaintingEnabled() an can switch to the needed
>> logic then.
>>
>> Just tell me your opinion (talking to all devs). Or maybe someone has a
>> better solution for this :D.
>>
>>
> It sounds good to me! I got this mail privately, maybe we should open up the discussion on the mailing list.
>
:-/ was a mistake. It was supposed to go to the list :D



More information about the kimageshop mailing list