Patch for thumbnail update in layerbox

[Sven Langkamp]

On Sun, Sep 19, 2010 at 1:34 PM, Boudewijn Rempt <boud at valdyas.org> wrote:

> On Sunday 19 September 2010, Dmitry Kazakov wrote:
> > >
> > > The the KisNodeGraphListener is extended by a method to notify about
> node
> > > changes. Nodes call it when the systemLocked is turned off. I used
> > > systemLocked as it only called once an operation is finished, so we
> don't do
> > > updates that are not needed.
> > > The node model manages a queue for the nodes that will be updated after
> a
> > > one second timeout.
> > >
> > > Any comments?
> > >
> >
> > I have two comments about this:
> > 1) I don't think it is very good to use systemLocked call for this. I'm
> not
> > sure this ability (to lock the system) should live in future releases.
> It's
> > not good idea to block UI for any reason. So i temped to deprecate it in
> the
> > future.
>
> Well, systemLocked only locks the gui for a particular layer, so it's
> pretty safe. I don' think we'll lose that. But I still think that using
> KisImage::void sigImageUpdated should be enough to kick off the thumbnails
> timer.
>
>
sigImageUpdated doesn't contain information about the node that should be
updated. With sigNodeChanged only the node that was changed with regenerate
it's preview image.

As Boud said systemLocked only blocks the current node. Even without the
systemLocked the node would have to be locked in some way. The queue that
was proposed isn't a solution as it would just delay changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kimageshop/attachments/20100919/093a3968/attachment.htm