<div class="gmail_quote">On Sun, Sep 19, 2010 at 1:34 PM, Boudewijn Rempt <span dir="ltr"><<a href="mailto:boud@valdyas.org">boud@valdyas.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div class="im">On Sunday 19 September 2010, Dmitry Kazakov wrote:<br>
> ><br>
> > The the KisNodeGraphListener is extended by a method to notify about node<br>
> > changes. Nodes call it when the systemLocked is turned off. I used<br>
> > systemLocked as it only called once an operation is finished, so we don't do<br>
> > updates that are not needed.<br>
> > The node model manages a queue for the nodes that will be updated after a<br>
> > one second timeout.<br>
> ><br>
> > Any comments?<br>
> ><br>
><br>
> I have two comments about this:<br>
> 1) I don't think it is very good to use systemLocked call for this. I'm not<br>
> sure this ability (to lock the system) should live in future releases. It's<br>
> not good idea to block UI for any reason. So i temped to deprecate it in the<br>
> future.<br>
<br>
</div>Well, systemLocked only locks the gui for a particular layer, so it's pretty safe. I don' think we'll lose that. But I still think that using KisImage::void sigImageUpdated should be enough to kick off the thumbnails timer.<br>
<br></blockquote><div><br>sigImageUpdated doesn't contain information about the node that should be updated. With sigNodeChanged only the node that was changed with regenerate it's preview image.<br><br>As Boud said systemLocked only blocks the current node. Even without the systemLocked the node would have to be locked in some way. The queue that was proposed isn't a solution as it would just delay changes.<br>
</div></div>