Patch for thumbnail update in layerbox
boud at valdyas.org
Sun Sep 19 14:04:42 CEST 2010
On Sunday 19 September 2010, Sven Langkamp wrote:
> On Sun, Sep 19, 2010 at 1:34 PM, Boudewijn Rempt <boud at valdyas.org> wrote:
> > On Sunday 19 September 2010, Dmitry Kazakov wrote:
> > > >
> > > > The the KisNodeGraphListener is extended by a method to notify about
> > node
> > > > changes. Nodes call it when the systemLocked is turned off. I used
> > > > systemLocked as it only called once an operation is finished, so we
> > don't do
> > > > updates that are not needed.
> > > > The node model manages a queue for the nodes that will be updated after
> > a
> > > > one second timeout.
> > > >
> > > > Any comments?
> > > >
> > >
> > > I have two comments about this:
> > > 1) I don't think it is very good to use systemLocked call for this. I'm
> > not
> > > sure this ability (to lock the system) should live in future releases.
> > It's
> > > not good idea to block UI for any reason. So i temped to deprecate it in
> > the
> > > future.
> > Well, systemLocked only locks the gui for a particular layer, so it's
> > pretty safe. I don' think we'll lose that. But I still think that using
> > KisImage::void sigImageUpdated should be enough to kick off the thumbnails
> > timer.
> sigImageUpdated doesn't contain information about the node that should be
> updated. With sigNodeChanged only the node that was changed with regenerate
> it's preview image.
Yes, that's right. One thing I might have missed is what happens when painting with the freehand tool -- that doesn't use systemlocked, does it?
Boudewijn Rempt | http://www.valdyas.org
Ceterum censeo lapsum particulorum probae delendum esse
More information about the kimageshop