koffice/krita/ui/tool

[Boudewijn Rempt]

On Saturday 07 November 2009, LukasT.dev at gmail.com wrote:
> On Saturday 07 November 2009 23:15:16 Boudewijn Rempt wrote:
> > On Saturday 07 November 2009, Boudewijn Rempt wrote:
> > > SVN commit 1046086 by rempt:
> > >
> > > Select from the projection with ctrl, from the current layer with
> > >  ctrl-shift
> > >
> > > Follow Enkithan's advise.
> > >
> > > Note: using the settings of the separate color picker tool is what
> > > Photoshop does, but that requires us to store the tool settings, which
> > > we currently don't do.
> >
> > Lukas correctly reminds me that I should have offered this and  "SVN
> > commit 1046077 Add color picker and pan mode to freehand tools" for
> > review before committing. This is a mistake on my part, and I would like
> > to invite some after-the-fact review. Should I first revert?
> >
> > >  M  +2 -2      kis_tool_freehand.cc
> > >
> > >
> > > --- trunk/koffice/krita/ui/tool/kis_tool_freehand.cc #1046085:1046086
> > > @@ -130,7 +130,7 @@
> > >          return;
> > >
> > >      // control-click gets the color at the current point. For now,> > > 
> > > only with a ratio of 1 -    if (e->modifiers() == Qt::ControlModifier )
> > > { +    if (e->modifiers() == (Qt::ControlModifier | Qt::ShiftModifier))
> > > { if (e->button() == Qt::LeftButton)
> > >
> > >
> > > m_canvas->resourceProvider()->setResource(KoCanvasResource::ForegroundC
> > >ol o r, KisToolUtils::pick(currentNode()->paintDevice(), @@ -141,7
> > > +141,7 @@
> > >
> > >  convertToIntPixelCoord(e)));
> > >
> > >      }
> > > -    else if (e->modifiers() == (Qt::ControlModifier |
> > > Qt::ShiftModifier)) { +    else if (e->modifiers() ==
> > > Qt::ControlModifier ) {
> > >
> > >          if (e->button() == Qt::LeftButton)
> > >
> > >
> > > m_canvas->resourceProvider()->setResource(KoCanvasResource::ForegroundC
> > >ol o r,
> 
> I don't think you should revert.
> 
> I noticed that you use CTRL and I wanted to use CTRL for Duplicate Op to
>  setup the point where you duplicate. But Cyrille did not agree and I still
>  want to convince Cyrille to use CTRL to be used. Is the CTRL passed first
>  to paintop and then to the tool?

I used ctrl because gimp and mypaint use ctrl. However, I just noticed that 
photoshop uses alt, so I am fine with changing to alt as well. I probably 
should change the tool icon, too, since that's what both gimp and photoshop 
do. 

> So I will abuse this thread a little :/
> 
> Cyrille's two arguments for Shift in duplicate on IRC were :
> a) old Krita users can be mislead
> b) we might go back
> 
> a) I will make a blog post and will write forum post to spread the change
>  :) b) Why we want to go back?
> 
> I like Shift + drag  +0
> It is wishlist, that's why I select Shift for it +1
> We would be compatible with Gimp (duplicate op) +1
> Duplicate can use Shift+drag to change size +1
> 
> I don't know how to make keyboard shortcuts configurable. There is KDE
>  style config dialog and we should really use it. If you guide me, I will
>  write my code so that the keyboard shortcuts are configurable as much as
>  possible. I suppose you also will do that.

Well... The modifier keys for mouse actions are not keyboard shortcuts, 
actually. I'll propose a patch to implement wish 
https://bugs.kde.org/show_bug.cgi?id=138153 (Use keyboard to switch between 
foreground and background color) in a minute or so, and that uses real 
shortcuts.

I'm not sure whether configurability of the freehand tool modifiers is a big 
issue, but if we want it, we need to implement something ourselves. Either by 
having a page in the settings dialog where the modifiers can be selector, or 
by having a kind of presets, like "work like gimp", "work like photoshop", 
"work like krita 1.x".

> Because the current situation is that everybody prefers something different
>  -- we are people, right :) Sometimes it is hard to have consensus.

Indeed :-). 

-- 
Boudewijn Rempt | http://www.valdyas.org