koffice/krita/ui/tool

[LukasT.dev@gmail.com]

On Saturday 07 November 2009 23:15:16 Boudewijn Rempt wrote:
> On Saturday 07 November 2009, Boudewijn Rempt wrote:
> > SVN commit 1046086 by rempt:
> >
> > Select from the projection with ctrl, from the current layer with
> >  ctrl-shift
> >
> > Follow Enkithan's advise.
> >
> > Note: using the settings of the separate color picker tool is what
> > Photoshop does, but that requires us to store the tool settings, which
> > we currently don't do.
> 
> Lukas correctly reminds me that I should have offered this and  "SVN commit
> 1046077 Add color picker and pan mode to freehand tools" for review before
> committing. This is a mistake on my part, and I would like to invite some
> after-the-fact review. Should I first revert?
> 
> >  M  +2 -2      kis_tool_freehand.cc
> >
> >
> > --- trunk/koffice/krita/ui/tool/kis_tool_freehand.cc #1046085:1046086
> > @@ -130,7 +130,7 @@
> >          return;
> >
> >      // control-click gets the color at the current point. For now, only
> >  with a ratio of 1 -    if (e->modifiers() == Qt::ControlModifier ) {
> > +    if (e->modifiers() == (Qt::ControlModifier | Qt::ShiftModifier)) {
> >          if (e->button() == Qt::LeftButton)
> >
> > 
> > m_canvas->resourceProvider()->setResource(KoCanvasResource::ForegroundCol
> >o r, KisToolUtils::pick(currentNode()->paintDevice(), @@ -141,7 +141,7 @@
> >
> >  convertToIntPixelCoord(e)));
> >
> >      }
> > -    else if (e->modifiers() == (Qt::ControlModifier |
> > Qt::ShiftModifier)) { +    else if (e->modifiers() == Qt::ControlModifier
> > ) {
> >
> >          if (e->button() == Qt::LeftButton)
> >
> > 
> > m_canvas->resourceProvider()->setResource(KoCanvasResource::ForegroundCol
> >o r,
> 

I don't think you should revert.

I noticed that you use CTRL and I wanted to use CTRL for Duplicate Op to setup 
the point where you duplicate. But Cyrille did not agree and I still want to 
convince Cyrille to use CTRL to be used. Is the CTRL passed first to paintop 
and then to the tool?

So I will abuse this thread a little :/

Cyrille's two arguments for Shift in duplicate on IRC were :
a) old Krita users can be mislead
b) we might go back

a) I will make a blog post and will write forum post to spread the change :)
b) Why we want to go back? 

I like Shift + drag  +0
It is wishlist, that's why I select Shift for it +1
We would be compatible with Gimp (duplicate op) +1
Duplicate can use Shift+drag to change size +1

I don't know how to make keyboard shortcuts configurable. There is KDE style 
config dialog and we should really use it. If you guide me, I will write my 
code so that the keyboard shortcuts are configurable as much as possible. I 
suppose you also will do that.

Because the current situation is that everybody prefers something different -- 
we are people, right :) Sometimes it is hard to have consensus.