New Tiled Data Manager ideas and tests

[Schleimer, Ben]

It's a bug. The next time a user calls KisTileReadWriteProcessor::setupProcessor() or KisTileReadWriteProcessor::KisTileReadWriteProcessor() with different args and then calls copyData, dataIdx won't be set to the correct value.

cheers
ben




--- On Tue, 6/2/09, Dmitry Kazakov <dimula73 at gmail.com> wrote:

> From: Dmitry Kazakov <dimula73 at gmail.com>
> Subject: Re: New Tiled Data Manager ideas and tests
> To: "Krayon (KImageShop)" <kimageshop at kde.org>
> Date: Tuesday, June 2, 2009, 10:46 AM
> 
> 
> On Tue, Jun 2, 2009 at 7:51 PM,
> Bart Coppens <kde at bartcoppens.be>
> wrote:
> 
> 
> On Tuesday 02 June 2009 17:25:58 Dmitry Kazakov wrote:
> 
> > New commit r976769
> 
> (For reference:
> 
> http://websvn.kde.org/branches/work/koffice-intentivelyfeature-tiles-ng/krita/image/tiles3/kis_tile_processors.cc?r1=976769&r2=976768&pathrev=976769
> 
> 
> 
> )
> 
> 
> 
> > A strange thing! I changed only one line and
> processors started working 20%
> 
> > faster than old system. I don't know why. Could
> someone take a look.
> 
> Well it is probably because you change the meaning of
> the variable. In the old
> 
> version (const qint32 dataIdx), your variable is constant
> across the duration
> 
> of the function. In the new version, (static const qint32
> dataIdx) the
> 
> variabe is constant for _all_ invocations of the function
> (after the first
> 
> one).
> 
> 
> 
> Well... Thanks... I know about storage classes =) And i
> purposely  added 'static' class to ensure that
> indexFromPoint(m_dataLeftTop, m_dataStride) is called only
> once while creating processor-object. 
> 
> 
> The thing i can't understand is how
> 1multiplication+1addition could cause such a great overhead
> (0.560sec instead of 0.900sec)?!
> And more than that, why callgrind causes optimized version
> to slow down again?
> 
> 
> 
> Here are three outputs in attachments.
> 
> 
> 
> -- 
> Dmitry Kazakov
> 
> 
> -----Inline Attachment Follows-----
> 
> _______________________________________________
> kimageshop mailing list
> kimageshop at kde.org
> https://mail.kde.org/mailman/listinfo/kimageshop
>