Review Request: added a baseclass for all selection tools

Adam nospam at
Sat Dec 19 03:04:31 CET 2009

On Fri, 18 Dec 2009 23:09:11 +0100, Sven Langkamp  
<sven.langkamp at> wrote:

> On Fri, Dec 18, 2009 at 6:40 PM, Adam <nospam at> wrote:
>> Somehow this notification didn't get through..
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> -----------------------------------------------------------
>> Review request for KOffice.
>> Summary
>> -------
>> I added KisToolSelectBase as a base class for all selection tools and
>> refactored the tools in the selectiontools directory to use it. If this
>> patch will be accepted, I will also move KisToolSelectSimilar to the
>> selectiontools dir, add the new parent and implement the junior job
>> "implement shortcuts to switch between selection modes (add, subtract,
>> replace) for the Krita selection tools".
>> I noticed 2 bugs (crash in path select and lines not visible in  
>> polygonal,
>> already in the old version present), which I will also try to fix.
>> KisToolSelectPolygonal will need a new shortcut for deactivating.
> Looks good. I think it would be better to put the new base class in
> krita/ui/tool, makes it easier reusable.
> For the temporary line painting have a look at the shape tools. Lukas did
> already fix it there.
> While you are working on the actions you could also switch the  
> comboboxes in
> that widget to button groups.

I'm unsure, what you mean by button group. Something like this? [see  
Imo such a group box needs very much space, but otherwise this toolbox  
won't be visible the whole time, so it shouldn't be a problem.

Using Opera's revolutionary e-mail client:
-------------- next part --------------
A non-text attachment was scrubbed...
Name: selectToolBox.png
Type: image/png
Size: 12066 bytes
Desc: not available
Url : 

More information about the kimageshop mailing list