Review Request: added a baseclass for all selection tools

[Sven Langkamp]

On Fri, Dec 18, 2009 at 6:40 PM, Adam <nospam at xibo.at> wrote:

> Somehow this notification didn't get through..
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2415/
> -----------------------------------------------------------
>
> Review request for KOffice.
>
>
> Summary
> -------
>
> I added KisToolSelectBase as a base class for all selection tools and
> refactored the tools in the selectiontools directory to use it. If this
> patch will be accepted, I will also move KisToolSelectSimilar to the
> selectiontools dir, add the new parent and implement the junior job
> "implement shortcuts to switch between selection modes (add, subtract,
> replace) for the Krita selection tools".
>
> I noticed 2 bugs (crash in path select and lines not visible in polygonal,
> already in the old version present), which I will also try to fix.
> KisToolSelectPolygonal will need a new shortcut for deactivating.
>

Looks good. I think it would be better to put the new base class in
krita/ui/tool, makes it easier reusable.

For the temporary line painting have a look at the shape tools. Lukas did
already fix it there.
While you are working on the actions you could also switch the comboboxes in
that widget to button groups.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kimageshop/attachments/20091218/d5ee8099/attachment.htm