Review Request: added a baseclass for all selection tools

[Sven Langkamp]

On Sat, Dec 19, 2009 at 3:04 AM, Adam <nospam at xibo.at> wrote:

> On Fri, 18 Dec 2009 23:09:11 +0100, Sven Langkamp <sven.langkamp at gmail.com>
> wrote:
>
>  On Fri, Dec 18, 2009 at 6:40 PM, Adam <nospam at xibo.at> wrote:
>>
>>  Somehow this notification didn't get through..
>>>
>>> -----------------------------------------------------------
>>> This is an automatically generated e-mail. To reply, visit:
>>> http://reviewboard.kde.org/r/2415/
>>> -----------------------------------------------------------
>>>
>>> Review request for KOffice.
>>>
>>>
>>> Summary
>>> -------
>>>
>>> I added KisToolSelectBase as a base class for all selection tools and
>>> refactored the tools in the selectiontools directory to use it. If this
>>> patch will be accepted, I will also move KisToolSelectSimilar to the
>>> selectiontools dir, add the new parent and implement the junior job
>>> "implement shortcuts to switch between selection modes (add, subtract,
>>> replace) for the Krita selection tools".
>>>
>>> I noticed 2 bugs (crash in path select and lines not visible in
>>> polygonal,
>>> already in the old version present), which I will also try to fix.
>>> KisToolSelectPolygonal will need a new shortcut for deactivating.
>>>
>>>
>> Looks good. I think it would be better to put the new base class in
>> krita/ui/tool, makes it easier reusable.
>>
>> For the temporary line painting have a look at the shape tools. Lukas did
>> already fix it there.
>> While you are working on the actions you could also switch the comboboxes
>> in
>> that widget to button groups.
>>
>
> ok..
> I'm unsure, what you mean by button group. Something like this? [see
> attachment]
> Imo such a group box needs very much space, but otherwise this toolbox
> won't be visible the whole time, so it shouldn't be a problem.
>

Yes, like that. See QButtonGroup.
Instead of putting a box around them just align them in a row like Gimp
does. For the action button we have to replace the text by icons so that
they fit into one row too.

I have seen some mockups about future plans for that like
http://kexi-project.org/pics/2.2/alpha1/kexi-2.2-alpha1-groupbutton-mockup3.png,
but for now simple buttons will do.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kimageshop/attachments/20091219/5e6d59b6/attachment-0001.htm