<div class="gmail_quote">On Fri, Dec 18, 2009 at 6:40 PM, Adam <span dir="ltr"><<a href="mailto:nospam@xibo.at">nospam@xibo.at</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Somehow this notification didn't get through..<br>
<br>
-----------------------------------------------------------<br>
This is an automatically generated e-mail. To reply, visit:<br>
<a href="http://reviewboard.kde.org/r/2415/" target="_blank">http://reviewboard.kde.org/r/2415/</a><br>
-----------------------------------------------------------<br>
<br>
Review request for KOffice.<br>
<br>
<br>
Summary<br>
-------<br>
<br>
I added KisToolSelectBase as a base class for all selection tools and<br>
refactored the tools in the selectiontools directory to use it. If this<br>
patch will be accepted, I will also move KisToolSelectSimilar to the<br>
selectiontools dir, add the new parent and implement the junior job<br>
"implement shortcuts to switch between selection modes (add, subtract,<br>
replace) for the Krita selection tools".<br>
<br>
I noticed 2 bugs (crash in path select and lines not visible in polygonal,<br>
already in the old version present), which I will also try to fix.<br>
KisToolSelectPolygonal will need a new shortcut for deactivating.<br></blockquote><div><br>Looks good. I think it would be better to put the new base class in krita/ui/tool, makes it easier reusable.<br><br>For the temporary line painting have a look at the shape tools. Lukas did already fix it there.<br>
While you are working on the actions you could also switch the comboboxes in that widget to button groups.<br></div></div>