Replacing KisFilter::overlapMarginNeeded

Cyrille Berger cberger at cberger.net
Mon Dec 8 23:46:27 CET 2008


On Monday 08 December 2008, Matthew Woehlke wrote:
> Cyrille Berger wrote:
> > On a side note, when looking at this, I also noted that we were missing a
> > function in KisGenerator to specify which rectangle of the image is
> > affected by the generator (not all generators are going to work on the
> > full image, think about lensflare), for this I suggest:
> > * QRect KisGenerator::generatedRect( QRect _imageArea ) : return the
> > rectangle of generated pixels
>
> Eh? Is this written yet? 
... yes for at least six monthes now...

> (IOW, is there yet a non-trivial generator I 
> can look at as an example to try to start writing some of the others?)
no. But there are filter that behave as generator that could be considered as 
non trivial, and since a generator is a filter without a source layer it 
shouldn't be hard to extrapolate.

> That said, it seems like this should not be needed, since generators
> don't depend on the underlying content. IOW, can't Krita simply track
> internally what parts of a layer were filled by a generator when
> calculating what needs to be recomposited? Or do I miss something?
It could but then it might also depends on the configuration.

-- 
Cyrille Berger


More information about the kimageshop mailing list