Replacing KisFilter::overlapMarginNeeded

[Matthew Woehlke]

Cyrille Berger wrote:
> On Monday 08 December 2008, Matthew Woehlke wrote:
>> Cyrille Berger wrote:
>>> On a side note, when looking at this, I also noted that we were missing a
>>> function in KisGenerator to specify which rectangle of the image is
>>> affected by the generator (not all generators are going to work on the
>>> full image, think about lensflare), for this I suggest:
>>> * QRect KisGenerator::generatedRect( QRect _imageArea ) : return the
>>> rectangle of generated pixels
>> Eh? Is this written yet? 
> .... yes for at least six monthes now...
> 
>> (IOW, is there yet a non-trivial generator I 
>> can look at as an example to try to start writing some of the others?)
> no. But there are filter that behave as generator that could be considered as 
> non trivial, and since a generator is a filter without a source layer it 
> shouldn't be hard to extrapolate.

Weren't we going to move filters that don't use the input layer (e.g. 
lens flare) to generators ASAP. Prior to 2.0, preferably, at any rate? 
Or is it too late to do that? (The objective being to not break people's 
files when we do... or is there a seamless import plan already?)

I looked (briefly) for lens flare but didn't find it. I assume it is in 
krita/plugins somewhere? Mind if I take a crack at converting it to a 
generator?

>> That said, it seems like this should not be needed, since generators
>> don't depend on the underlying content. IOW, can't Krita simply track
>> internally what parts of a layer were filled by a generator when
>> calculating what needs to be recomposited? Or do I miss something?
> It could but then it might also depends on the configuration.

Not sure I follow. Do you mean that what is filled depends on the 
configuration (obviously), or that the configuration determines whether 
or not Krita itself can track what part of a generated layer is filled?

(Maybe I should ask how a generated layer is different from a painted 
layer in this context. I don't think it should be?)

-- 
Matthew
Please do not quote my e-mail address unobfuscated in message bodies.
-- 
"Do you do windows as well?"
"Only when I'm forced to deal with Microsoft..."
   -- from a story by Feech