Replacing KisFilter::overlapMarginNeeded

Matthew Woehlke mw_triad at users.sourceforge.net
Mon Dec 8 23:34:33 CET 2008


Cyrille Berger wrote:
> On a side note, when looking at this, I also noted that we were missing a 
> function in KisGenerator to specify which rectangle of the image is affected 
> by the generator (not all generators are going to work on the full image, 
> think about lensflare), for this I suggest:
> * QRect KisGenerator::generatedRect( QRect _imageArea ) : return the rectangle 
> of generated pixels

Eh? Is this written yet? (IOW, is there yet a non-trivial generator I 
can look at as an example to try to start writing some of the others?)

That said, it seems like this should not be needed, since generators 
don't depend on the underlying content. IOW, can't Krita simply track 
internally what parts of a layer were filled by a generator when 
calculating what needs to be recomposited? Or do I miss something?

-- 
Matthew
Please do not quote my e-mail address unobfuscated in message bodies.
-- 
"Do you do windows as well?"
"Only when I'm forced to deal with Microsoft..."
   -- from a story by Feech



More information about the kimageshop mailing list