Patch review for optimization in paintop

Bart Coppens kde at bartcoppens.be
Wed Sep 27 14:33:41 CEST 2006


On Wednesday 27 September 2006 14:24, Cyrille Berger wrote:
> Can anyone have a look at this patch ? It optimized greatly paintop
I didn't actually test it, but it looks ok. Just to make sure: if the profile 
is different, the m_dab will be recreated as well, right?

> Now, computeDab is still the expensive function for paintop (with 40% of
> its cost coming from creating/destroying iterators :'( ).
I think it'd be pretty easy to rewrite computeDab to use a rect iterator 
instead of maskHeight times a HLine one. But iirc, what really slows down 
stuff is the rescaling (at >100%) of the mask when pushing your tablet to 
100% pressure (which will make the dab bigger with the default options). 
Especially noticeable with big brush sizes iirc.

> PS: sometimes, I have discovered sysprof
Ah, I already heard about it, maybe it's time for me to try it out =)

Bart


More information about the kimageshop mailing list