Patch review for optimization in paintop

Cyrille Berger cberger at cberger.net
Wed Sep 27 14:24:54 CEST 2006


Hi

Can anyone have a look at this patch ? It optimized greatly paintop (compare 
drawing at zoom = 10% with the patch and without), I didn't noticed any side 
effect, but I don't want to introduce regression in 1.6.
Now, computeDab is still the expensive function for paintop (with 40% of its 
cost coming from creating/destroying iterators :'( ).

PS: sometimes, I have discovered sysprof 
(http://www.google.com/search?q=sysprof&ie=UTF-8&oe=UTF-8) for profiling, 
it's similar than oprofile, a little bit less powerfull, but much more 
easier. And unlike cachegrind, there is nearly no speed decrease.
I have been very successfull to find where to optimize with sysprof, I 
strongly advise you to test it :)
-- 
--- Cyrille Berger ---
-------------- next part --------------
A non-text attachment was scrubbed...
Name: optimization.paintop.diff
Type: text/x-diff
Size: 1776 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kimageshop/attachments/20060927/e47fea9e/attachment.bin 


More information about the kimageshop mailing list