Iterator

Boudewijn Rempt boud at valdyas.org
Sat Jan 28 09:12:12 CET 2006


On Saturday 28 January 2006 17:58, Cyrille Berger wrote:
> Hello,
>
> While working on optimizing and finishing KisConvolutionPainter, I found
> out (that maybe not new) that we lost a lot of time in creating iterators,
> this is much a problem for KisVLineIteratorPixel and KisHLineIteratorPixel,
> as you need to recreate the iterator each time you change the line. I think
> we might expand them with two new functions :
> KisHLineIteratorPixel::nextRow go to the next row
> KisVLineIteratorPixel::nextCol go to the next col
>
> (note that the behaviour would be quiet different from KisRectIterator)
>
> What do you think ?

Sounds like a very workable idea. As far as I'm concerned you can add it and 
document it. However, be careful not to change existing code that uses the 
iterators nor the meaning of existing code inside the iterator. I'm sure it 
will give regressions if we do that.

-- 
Boudewijn Rempt 
http://www.valdyas.org/fading/index.cgi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kimageshop/attachments/20060128/9507776f/attachment.pgp 


More information about the kimageshop mailing list