Layers, layergroups, dockwindow, preview and dynamic layersize

[Boudewijn Rempt]

On Tuesday 29 June 2004 15:42, Casper Boemann wrote:

<snip lots of good work>

>
> Krita compiles,  and I would like to commit the changes, however I don't
> have cvs rights.

If you send me the patch, I'll review it and commit. Please make sure it's a 
unified diff (cvs diff -u), and also make sure things like indentation and 
coding standards conform to the HACKING file in the Krita root. (Yes, I know 
-- using tabs sucks, and one would really prefer four spaces, I would prefer 
that too, but there we are, and lets keep it consistent :-).

>
> The next part of transformation to dynamic layers (I'm not there yet) is
> removing references to tilenumbers. A tile_iterator needs to be designed
> and used.
>

Please keep in mind that in the next refactoring I will try to completely hide 
the tile manager behind some kind of facade; and take a peek at Cyrille's 
iterarors (kis_iterators.h) -- they are not perfect, but we're getting 
somewhere.

> The final part would be to allow growing of the matrix of tiles when
> writing outside current dimensions, and returning a blank tile when reading
> outside.

When you first drew my attention to this point, I started thinking about our 
tile manager. If you allow unlimited extents, then there's no reason to 
actually allocate tiles even within the image size if there is no image data 
(that is, if all there is nothing but the background), we don't need to 
actually allocate a tile. Of course, I am not sure whether we do allocate a 
tile at present in that case -- I find the tile manager a little hard to 
understand.

> Tell me what you think

Show me the code, and I will tell you :-).

-- 
Boudewijn Rempt | http://www.valdyas.org/fading/index.cgi