Removal of KJS::getString()

[Maciej Stachowiak]

On Oct 11, 2004, at 4:35 AM, Harri Porten wrote:

> Hi,
>
> we had been discussing the use of the getString() function in
> ecma/kjs_*.cpp for quite a while. It returns the passed string argument
> unless it's empty - in which case Null is returned.
>
> Since we don't know about any case where above mechanism was needed (we
> just found cases were it was causing bugs) we decided to drop all 
> usage of
> getString(). This move was supported by the spec pointer given in
> http://bugs.kde.org/83602.

Based on later commits it seems like some of these were actually 
needed. Is this all sorted out now? I'd likee to take the fix for 
WebCore but I'd rather wait until you figure out the right places to 
keep it.

> The only remaining use of getString() is in xmlserializer.cpp. I don't
> dare to touch this occurance as I don't know the code. Could anyone 
> from
> Apple comment on whether getString() is really needed at this place? If
> not we'll remove it completely and I suggest that you do the same for
> WebCore.

I'll take a look.

  - Maciej