Removal of KJS::getString()

Harri Porten porten at froglogic.com
Fri Oct 15 14:19:52 CEST 2004


On Thu, 14 Oct 2004, Maciej Stachowiak wrote:

> Based on later commits it seems like some of these were actually
> needed.

Wanted to post a "warning" here. Later forgot. Sorry.

> Is this all sorted out now?

Probably not :(

> I'd likee to take the fix for WebCore but I'd rather wait until you
> figure out the right places to keep it.

David's stance was that only tests for each property would guarantee a
safe conversion. But who's going to write those? ;(

David, I remember you had a distinction for cases where getString() would
still have to be used?

> > The only remaining use of getString() is in xmlserializer.cpp. I don't
> > dare to touch this occurance as I don't know the code. Could anyone
> > from Apple comment on whether getString() is really needed at this
> > place? If not we'll remove it completely and I suggest that you do the
> > same for WebCore.
>
> I'll take a look.

Thanks,

Harri.



More information about the Khtml-devel mailing list