Removal of KJS::getString()
Harri Porten
porten at froglogic.com
Mon Oct 11 13:35:47 CEST 2004
Hi,
we had been discussing the use of the getString() function in
ecma/kjs_*.cpp for quite a while. It returns the passed string argument
unless it's empty - in which case Null is returned.
Since we don't know about any case where above mechanism was needed (we
just found cases were it was causing bugs) we decided to drop all usage of
getString(). This move was supported by the spec pointer given in
http://bugs.kde.org/83602.
The only remaining use of getString() is in xmlserializer.cpp. I don't
dare to touch this occurance as I don't know the code. Could anyone from
Apple comment on whether getString() is really needed at this place? If
not we'll remove it completely and I suggest that you do the same for
WebCore.
Thanks,
Harri.
More information about the Khtml-devel
mailing list