[Kget] Fwd: Re: [PATCH] New Drop-Target-Download-Dialog

[Lukas Appelhans]

Am Donnerstag, 4. Oktober 2007 17:56:06 schrieb Pino Toscano:
> Alle giovedì 04 ottobre 2007, Lukas Appelhans ha scritto:
> > So, completely new Patch, should work now with Normal-Links and
> > Link-Lists (but I haven't tested it, b/c of missing one :-( )...
>
> Apart from the needed testing, could you please fixup your totally messy
> indentation style?
Yes, hope this one is better...
>
> Plus, some minor nipticks:
> * if (foo == true) - redundant, if (foo) is cleaner
fixed 
> * void NewTransferWidget::setUrl(KUrl::List urls)
>   → void NewTransferWidget::setUrl(const KUrl::List &urls)
hope this too
> * dialog.result() == 1 - what does '1' mean? QDialog::Accepted?
> QDialog::Rejected?
fixed
> -
>
> | +       else
> | +           ;
>
> ??
fixed...

Cheers 

Lukas




-------------- next part --------------
A non-text attachment was scrubbed...
Name: kgetdialog2.diff
Type: text/x-diff
Size: 10955 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kget/attachments/20071004/590702b3/attachment-0001.bin