[Kget] Fwd: Re: [PATCH] New Drop-Target-Download-Dialog

[Pino Toscano]

Alle giovedì 04 ottobre 2007, Lukas Appelhans ha scritto:
> So, completely new Patch, should work now with Normal-Links and Link-Lists
> (but I haven't tested it, b/c of missing one :-( )...

Apart from the needed testing, could you please fixup your totally messy 
indentation style?

Plus, some minor nipticks:
* if (foo == true) - redundant, if (foo) is cleaner
* void NewTransferWidget::setUrl(KUrl::List urls)
  → void NewTransferWidget::setUrl(const KUrl::List &urls)
* dialog.result() == 1 - what does '1' mean? QDialog::Accepted? 
QDialog::Rejected?
-
| +       else
| +           ;
??

-- 
Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/kget/attachments/20071004/8bafdc2c/attachment.pgp