[Kget] Fwd: Re: [PATCH] New Drop-Target-Download-Dialog

[Pino Toscano]

Alle giovedì 04 ottobre 2007, Lukas Appelhans ha scritto:
> Am Donnerstag, 4. Oktober 2007 17:56:06 schrieb Pino Toscano:
> > Alle giovedì 04 ottobre 2007, Lukas Appelhans ha scritto:
> > > So, completely new Patch, should work now with Normal-Links and
> > > Link-Lists (but I haven't tested it, b/c of missing one :-( )...
> >
> > Apart from the needed testing, could you please fixup your totally messy
> > indentation style?
>
> Yes, hope this one is better...

Not really - most of it happily ignores the style written in the kget/HACKING 
file, especially when it comes to:
- indentation (lines with 0 characters?)
- whitespaces (mixup of tabs and spaces)
- position of the brackets (that are always "... foo;}" in your code)

Note: I don't want to obstruct your work, just to make clear that using a 
clean coding style, and respecting the existing style of a project, makes 
your and the other developers' life *much* easier. 

-- 
Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/kget/attachments/20071004/68c4d6ff/attachment.pgp