D29178: [dolphin] : Mac integration

[René J.V. Bertin]

rjvbb added inline comments.

INLINE COMMENTS

> feverfew wrote in main.cpp:224-225
> This goes against this diff: https://phabricator.kde.org/D23672
> 
> `mainWindow` needs to be created before these two classes are instantiated (well, in particular KDBusService but cleaner to do both at the same time). See the note in the class description: https://api.kde.org/frameworks/kdbusaddons/html/classKDBusService.html

Not that I am against this change because it means the main window is created even quicker, but just how many tabs do you need to open (and how, exactly) to observe the hanging?

FWIW, having the "open folders in tabs" settings under startup and not under general/behaviour is confusing and illogical to me...

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D29178

To: rjvbb, #dolphin, elvisangelaccio, feverfew
Cc: feverfew, broulik, meven, kfm-devel, #dolphin, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, fbampaloukas, alexde, Codezela, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, rdieter, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200426/78a641c6/attachment.htm>