D29178: [dolphin] : Mac integration

[Alexander Saoutkin]

feverfew requested changes to this revision.
feverfew added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> main.cpp:224-225
> +    // handling (on Mac) as soon as possible.
> +    KDBusService dolphinDBusService;
> +    DBusInterface interface;
> +

This goes against this diff: https://phabricator.kde.org/D23672

`mainWindow` needs to be created before these two classes are instantiated (well, in particular KDBusService but cleaner to do both at the same time). See the note in the class description: https://api.kde.org/frameworks/kdbusaddons/html/classKDBusService.html

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D29178

To: rjvbb, #dolphin, elvisangelaccio, feverfew
Cc: feverfew, broulik, meven, kfm-devel, #dolphin, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, fbampaloukas, alexde, Codezela, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, rdieter, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20200425/91df1a37/attachment.htm>