D24195: WebEnginePart: A new tab requested by user is not a popup

[David Faure]

dfaure added a comment.


  Then that bool is misused further down.
  
  "requested by user" should be true if requested by user, and false otherwise. Anything else makes the code really hard to understand.
  
  From what you're saying, the BrowserArgs code should check for type != QWebEnginePage::NavigationTypeOther explicitly, rather than using the bool "requested by user".

REPOSITORY
  R226 Konqueror

REVISION DETAIL
  https://phabricator.kde.org/D24195

To: marten, #plasma, #konqueror, dfaure, stefanocrocco
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20191016/67556c57/attachment.htm>