D24195: WebEnginePart: A new tab requested by user is not a popup

Jonathan Marten noreply at phabricator.kde.org
Tue Oct 15 11:40:16 BST 2019


marten marked 2 inline comments as done.
marten added inline comments.

INLINE COMMENTS

> dfaure wrote in webenginepage.cpp:774
> I think you want to edit this condition instead. The point of this bool is "this action was requested by the user". If the condition is incorrect, this is where it should be fixed.

See update diff comment

REPOSITORY
  R226 Konqueror

REVISION DETAIL
  https://phabricator.kde.org/D24195

To: marten, #plasma, #konqueror, dfaure, stefanocrocco
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20191015/ab024241/attachment.htm>


More information about the kfm-devel mailing list