D24195: WebEnginePart: A new tab requested by user is not a popup

[Jonathan Marten]

marten updated this revision to Diff 68133.
marten marked an inline comment as done.
marten added a comment.


  Updated in accordance with review comments, variable names corresponding to what they actually do.
  
  Not sure whether the '!part() && !isMainFrame' condition is significant and needs to be before the '!actionRequestsNewTab' test, i.e. whether it should read:
  
    if (actionRequestedByUser) {
      if (!part() && !isMainFrame) {
        return false;
      }
      if (!actionRequestsNewTab) {
        // ask the question
        ...
  
  but doing this means the question block would have to be reindented.

REPOSITORY
  R226 Konqueror

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24195?vs=67956&id=68133

REVISION DETAIL
  https://phabricator.kde.org/D24195

AFFECTED FILES
  webenginepart/src/webenginepage.cpp

To: marten, #plasma, #konqueror, dfaure, stefanocrocco
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20191017/26d2f7e3/attachment.htm>