D24195: WebEnginePart: A new tab requested by user is not a popup

[Jonathan Marten]

marten updated this revision to Diff 67956.
marten added a comment.


  If you mean to incorporate the tests directly into actionRequestedByUser:
  
    const bool actionRequestedByUser = type != QWebEnginePage::NavigationTypeOther &&
      m_type != QWebEnginePage::WebBrowserBackgroundTab &&
      m_type != QWebEnginePage::WebBrowserTab;
    if (actionRequestedByUser) { ...
  
  it doesn't seem to be possible because that bool is used not only to control whether the question is asked but also to set KParts::OpenUrlArguments below.  Setting the changed value here also makes anything that should be opened in a new tab open in a new window instead.
  
  Adding the tests for m_type conditions to the if (actionRequestedByUser) suppresses the question and opens tabs correctly;  the block does not now need to be indented.

REPOSITORY
  R226 Konqueror

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24195?vs=66757&id=67956

REVISION DETAIL
  https://phabricator.kde.org/D24195

AFFECTED FILES
  webenginepart/src/webenginepage.cpp

To: marten, #plasma, #konqueror, dfaure, stefanocrocco
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20191015/105ecb15/attachment.htm>