D24195: WebEnginePart: A new tab requested by user is not a popup

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> webenginepage.cpp:774
>  
>          const bool actionRequestedByUser = type != QWebEnginePage::NavigationTypeOther;
>  

I think you want to edit this condition instead. The point of this bool is "this action was requested by the user". If the condition is incorrect, this is where it should be fixed.

> webenginepage.cpp:780
>              }
> +            if (m_type!=QWebEnginePage::WebBrowserBackgroundTab && m_type!=QWebEnginePage::WebBrowserTab) {
>              const KParts::HtmlSettingsInterface::JSWindowOpenPolicy policy = WebEngineSettings::self()->windowOpenPolicy(reqUrl.host());

coding style: spaces around `!=`

REPOSITORY
  R226 Konqueror

REVISION DETAIL
  https://phabricator.kde.org/D24195

To: marten, #plasma, #konqueror, dfaure, stefanocrocco
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20191015/b5d14c35/attachment.htm>