D25257: refactor(search): De-couple baloo URL parsing logic from UI

Stefan BrĂ¼ns noreply at phabricator.kde.org
Mon Nov 11 22:33:40 GMT 2019


bruns added inline comments.

INLINE COMMENTS

> elvisangelaccio wrote in dolphinquerymodel.cpp:60-63
> Well it's a bit... unusual, at least in dolphin we never use a plain C array of QLatin1Strings

Probably because iterating over a plain C array was awkward before C++11 range-based for loops. Array is preferred, as it needs no allocation and does one pointer dereference less.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D25257

To: iasensio, #dolphin, elvisangelaccio, bruns
Cc: bruns, kfm-devel, pberestov, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20191111/e7b26066/attachment.htm>


More information about the kfm-devel mailing list