D25257: refactor(search): De-couple baloo URL parsing logic from UI
Ismael Asensio
noreply at phabricator.kde.org
Tue Nov 12 22:19:43 GMT 2019
iasensio updated this revision to Diff 69655.
iasensio marked 12 inline comments as done.
iasensio added a comment.
Address inline comments
- Address comments in header
- Move isSearchTerm() into an anonymous namespace
- Use const value in for-range loop
- Rename class
REPOSITORY
R318 Dolphin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25257?vs=69598&id=69655
BRANCH
model_view_parsing
REVISION DETAIL
https://phabricator.kde.org/D25257
AFFECTED FILES
src/CMakeLists.txt
src/search/dolphinfacetswidget.cpp
src/search/dolphinquery.cpp
src/search/dolphinquery.h
src/search/dolphinsearchbox.cpp
src/search/dolphinsearchbox.h
To: iasensio, #dolphin, elvisangelaccio, bruns
Cc: bruns, kfm-devel, pberestov, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20191112/2f01422e/attachment.htm>
More information about the kfm-devel
mailing list