D25257: refactor(search): De-couple baloo URL parsing logic from UI

[Elvis Angelaccio]

elvisangelaccio added inline comments.

INLINE COMMENTS

> bruns wrote in dolphinquerymodel.cpp:55-57
> The intention is to first factor the model out, i.e. no behavior changes.
> 
> Afterwards, the model can be changed to e.g. use Baloo::AdvancedQueryParser, which splits out *all* terms with a prefix (modified, type, rating, ...). The Widget can then pick out the ones it handles specifically and keep the remainder verbatim.

Ah right, I didn't realize this is copied from DolphinFacetsWidget's implementation.

> bruns wrote in dolphinquerymodel.cpp:60-63
> `QLatin1String x[] = {...}` is definitely simpler then `QStringList`.

Well it's a bit... unusual, at least in dolphin we never use a plain C array of QLatin1Strings

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D25257

To: iasensio, #dolphin, elvisangelaccio, bruns
Cc: bruns, kfm-devel, pberestov, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20191111/6eb5e21b/attachment.htm>