D19856: find ruby gems & make coverage conditional on BUILD_COVERAGE

[Harald Sitter]

sitter added inline comments.

INLINE COMMENTS

> elvisangelaccio wrote in CMakeLists.txt:8
> Why REQUIRED? This gem is only needed for the test, right?
> 
> Would it make sense to make it optional and only run the test if the gem is found?

My thinking is that its part of the test suite, so unless you build with BUILD_TESTING=OFF you must have the test run when you ctest the project. It also prevents accidentally not running the tests on CI (missing dep, broken ruby etc.).
Seeing as I am not the maintainer of dolphin I can also make it optional if that is preferred though :P

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D19856

To: sitter, #dolphin
Cc: elvisangelaccio, kfm-devel, alexde, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190319/d453bcc0/attachment.htm>