D19856: find ruby gems & make coverage conditional on BUILD_COVERAGE

[Elvis Angelaccio]

elvisangelaccio accepted this revision.
elvisangelaccio added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> sitter wrote in CMakeLists.txt:8
> My thinking is that its part of the test suite, so unless you build with BUILD_TESTING=OFF you must have the test run when you ctest the project. It also prevents accidentally not running the tests on CI (missing dep, broken ruby etc.).
> Seeing as I am not the maintainer of dolphin I can also make it optional if that is preferred though :P

Good point. Go for it :)

REPOSITORY
  R318 Dolphin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19856

To: sitter, #dolphin, elvisangelaccio
Cc: elvisangelaccio, kfm-devel, alexde, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190320/1ab6255e/attachment.htm>