D19856: find ruby gems & make coverage conditional on BUILD_COVERAGE

[Elvis Angelaccio]

elvisangelaccio added inline comments.

INLINE COMMENTS

> CMakeLists.txt:8
> +
> +find_gem(test-unit REQUIRED)
> +set_package_properties(Gem:test-unit PROPERTIES

Why REQUIRED? This gem is only needed for the test, right?

Would it make sense to make it optional and only run the test if the gem is found?

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D19856

To: sitter, #dolphin
Cc: elvisangelaccio, kfm-devel, alexde, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190318/fc409e6c/attachment.htm>