D22420: Fix an issue with focus lost after closing terminal panel

[Elvis Angelaccio]

elvisangelaccio added a comment.


  This issue was supposed to be fixed by commit 4e40fe810d324 <https://phabricator.kde.org/R318:4e40fe810d324e69eeb824e40011e509e6676aaf> but it seems it got reintroduced in the past months.
  
  Could you try to `git bisect` it to figure out when this happend?

INLINE COMMENTS

> dolphinmainwindow.cpp:754
>  {
> -    if (m_terminalPanel->isHiddenInVisibleWindow()) {
> +    if (m_terminalPanel->isHiddenInVisibleWindow() && m_activeViewContainer) {
>          m_activeViewContainer->view()->setFocus();

This looks like an unrelated change, if it's not can you explain why we need it?

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D22420

To: AndreyYashkin, #dolphin
Cc: elvisangelaccio, kfm-devel, aprcela, fprice, fbampaloukas, alexde, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190714/7d20426b/attachment.htm>