D22420: Fix an issue with focus lost after closing terminal panel
Andrey Yashkin
noreply at phabricator.kde.org
Fri Jul 12 14:01:45 BST 2019
AndreyYashkin created this revision.
AndreyYashkin added a reviewer: Dolphin.
AndreyYashkin added a project: Dolphin.
AndreyYashkin requested review of this revision.
REVISION SUMMARY
After leaving terminal with Ctrl-D or exit commands the input focus isn't set back to the folder view. The problem appears, because //TerminalPanel::isHiddenInVisibleWindow
// returns not what it supposed to return. I moved unwanted checks from it inside //TerminalPanel::dockVisibilityChanged//
BUG: 407979
TEST PLAN
1. Open Dolphin
2. Press F4 <https://phabricator.kde.org/F4> to open the terminal panel
3. Type exit<Enter> or press Ctrl-D
4. Check current focus widget
REPOSITORY
R318 Dolphin
REVISION DETAIL
https://phabricator.kde.org/D22420
AFFECTED FILES
src/dolphinmainwindow.cpp
src/panels/terminal/terminalpanel.cpp
To: AndreyYashkin, #dolphin
Cc: kfm-devel, fprice, fbampaloukas, alexde, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190712/461e35a0/attachment.htm>
More information about the kfm-devel
mailing list