D22420: Fix an issue with focus lost after closing terminal panel

Andrey Yashkin noreply at phabricator.kde.org
Mon Jul 15 14:08:51 BST 2019


AndreyYashkin marked an inline comment as done.
AndreyYashkin added a comment.


  In D22420#495467 <https://phabricator.kde.org/D22420#495467>, @elvisangelaccio wrote:
  
  > This issue was supposed to be fixed by commit 4e40fe810d324 <https://phabricator.kde.org/R318:4e40fe810d324e69eeb824e40011e509e6676aaf> but it seems it got reintroduced in the past months.
  >
  > Could you try to `git bisect` it to figure out when this happend?
  
  
  It seems that it was not fixed. I can reproduce the problem with 4e40fe810d324 <https://phabricator.kde.org/R318:4e40fe810d324e69eeb824e40011e509e6676aaf>.

INLINE COMMENTS

> elvisangelaccio wrote in dolphinmainwindow.cpp:754
> This looks like an unrelated change, if it's not can you explain why we need it?

//m_activeViewContainer// is //NULL// when Dolphin starts and without this change app crashes.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D22420

To: AndreyYashkin, #dolphin
Cc: elvisangelaccio, kfm-devel, aprcela, fprice, fbampaloukas, alexde, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190715/06b70527/attachment.htm>


More information about the kfm-devel mailing list