D15929: Add a 'Properties' entry in the Places panel context menu

[Thomas Surrel]

thsurrel added inline comments.

INLINE COMMENTS

> elvisangelaccio wrote in placesitemmodel.cpp:302
> The dialog needs a parent, otherwise the window stack will be wrong.

On the corresponding line in a previous version, anthonyfieroni had commented: "Don't use parent when it is not needed, Qt::WA_DeleteOnClose is fair enough."
Now I am a bit confused when parent is needed or not ...

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D15929

To: thsurrel, #dolphin, #plasma, #vdg, ngraham, elvisangelaccio
Cc: anthonyfieroni, elvisangelaccio, cfeck, ngraham, abetts, kfm-devel, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20181007/f9ced1b9/attachment.htm>