D15929: Add a 'Properties' entry in the Places panel context menu

[Elvis Angelaccio]

elvisangelaccio requested changes to this revision.
elvisangelaccio added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> placesitemmodel.cpp:302
> +    if (item) {
> +        KPropertiesDialog* dialog = new KPropertiesDialog(item->url());
> +        dialog->setAttribute(Qt::WA_DeleteOnClose);

The dialog needs a parent, otherwise the window stack will be wrong.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D15929

To: thsurrel, #dolphin, #plasma, #vdg, ngraham, elvisangelaccio
Cc: anthonyfieroni, elvisangelaccio, cfeck, ngraham, abetts, kfm-devel, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20181007/a335ce7c/attachment.htm>