D15929: Add a 'Properties' entry in the Places panel context menu

Nathaniel Graham noreply at phabricator.kde.org
Sat Oct 6 23:45:06 BST 2018


ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Code looks nice and clean now, and it works well. Maybe wait for @elvisangelaccio and/or @anthonyfieroni to give their thumbs-up as well before landing the patch.
  
  In D15929#336835 <https://phabricator.kde.org/D15929#336835>, @elvisangelaccio wrote:
  
  > I'm pretty sure this can be implemented in `KFilePlacesModel` without the need to duplicate the feature here in dolphin.
  
  
  Looks like no, unfortunately. D15973 <https://phabricator.kde.org/D15973> does not automatically result in Dolphin getting the feature.

REPOSITORY
  R318 Dolphin

BRANCH
  arc_properties (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15929

To: thsurrel, #dolphin, #plasma, #vdg, ngraham
Cc: anthonyfieroni, elvisangelaccio, cfeck, ngraham, abetts, kfm-devel, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20181006/0415927b/attachment.htm>


More information about the kfm-devel mailing list