D12094: Modify "Find" button to be a toggle, tracking state across tabs & split views

[Henrik Fehlauer]

rkflx added a comment.


  Thanks for not forgetting about this…
  
  In D12094#258177 <https://phabricator.kde.org/D12094#258177>, @sharvey wrote:
  
  > Try the Split button. I don't believe it's a proper `toggle` button. The state doesn't change, only the icon.
  
  
  Sure, you could look at this button to get inspiration from how it was implemented.
  
  > Perhaps we could change the magnifying glass icon to one with a red `X` over it to indicate "Find Off"?
  
  There already is a standard behaviour for showing what we want (i.e. normal and toggled). Let's not work around our issues in implementing this by simply changing of how it should work. The Split button is special, because it isn't a toggle but can affect two different tabs.
  
  Nevertheless, Find should work like Preview, only the shortcut handling should be different (focus instead of closing). Maybe you could try to attack the problem from the shortcut handling angle?

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D12094

To: sharvey, ngraham, elvisangelaccio, #dolphin
Cc: anthonyfieroni, rkflx, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180504/365a4944/attachment.htm>