D10960: Ask for confirmation when Closing Dolphin windows with a terminal panel running a program

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> rkflx wrote in dolphinmainwindow.cpp:401
> Okay, looking at the new Okular dialog, I'm pretty sure it should work like this:
> 
> - "Are you sure"-type dialog: Action is default.
> - "Discard changes"-type dialog: Cancel is default.
> 
> IOW, window state is less important (but still worth a confirmation) than unsaved user files (which //are// worth a warning).

Hmm, you make some good points. I'll have a think.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D10960

To: rominf, #dolphin, ngraham, elvisangelaccio
Cc: elvisangelaccio, markg, ngraham, rkflx, broulik, #dolphin, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180313/e8f8a6ce/attachment.htm>