D10960: Ask for confirmation when Closing Dolphin windows with a terminal panel running a program

[Henrik Fehlauer]

rkflx added inline comments.

INLINE COMMENTS

> rkflx wrote in dolphinmainwindow.cpp:401
> Okay, looking at the new Okular dialog, I'm pretty sure it should work like this:
> 
> - "Are you sure"-type dialog: Action is default.
> - "Discard changes"-type dialog: Cancel is default.
> 
> IOW, window state is less important (but still worth a confirmation) than unsaved user files (which //are// worth a warning).

Cannot edit inline comments, therefore let me clarify:

> "Discard changes"-type dialog: Cancel is default.

For unsaved changes, the "Save" action should be default, of course. What I meant here was when you can only choose between losing all work and cancelling.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D10960

To: rominf, #dolphin, ngraham, elvisangelaccio
Cc: elvisangelaccio, markg, ngraham, rkflx, broulik, #dolphin, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180313/14743d49/attachment.htm>